Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing: extra files in repository #9

Open
elimoss opened this issue Mar 11, 2019 · 5 comments
Open

Preprocessing: extra files in repository #9

elimoss opened this issue Mar 11, 2019 · 5 comments
Assignees

Comments

@elimoss
Copy link
Contributor

elimoss commented Mar 11, 2019

I've looked over the preprocessing repository, and there appears to be quite a bit of extraneous files and directories in the repository. Also, I'm not too sure which preprocessing*.nf file is the current workflow. To address this, please do the following and let me know so I can check it over again:

  • use git rm to remove files which are not code that you have written or other materials needed to run the pipeline. In particular, the .nextflow folder and .nextflow.log.* files should be removed.
  • use git mv to move the file containing the current workflow to h3ameta/preprocessing/preprocessing.nf, and remove the other similar files. That way it will be clear which file we should look at.

Please let me know if you have any questions about this : )

@elimoss elimoss self-assigned this Mar 11, 2019
@elimoss
Copy link
Contributor Author

elimoss commented Mar 11, 2019

whoop, side issue, adeyemi and abdul don't have github accounts, so i can't assign you to this issue! I'll follow up on Slack and get you on board.

@Rahmmy
Copy link

Rahmmy commented Mar 13, 2019

Hello Eli,
Thanks for your support yesterday. All redundant files have been removed and working files moved to the requested location. The h3ameta/preprocessing/preprocessing.nf is our working nextflow script sheet.

@Rahmmy
Copy link

Rahmmy commented Mar 13, 2019

so my issue is that there is a # in my trimmomatic script (preprocessing.nf) which nextflow rather identity's as an error.... Any suggestions please?

@Rahmmy
Copy link

Rahmmy commented Mar 13, 2019

The processes I'm running is

_process runTrimmomatic{

   input: file in_file 
    output:
    file("results") into step3_ch
     publishDir "results/TrimmedData"

    script:
    """
     #!/bin/bash

     input="/home/abdulrahman/h3ameta/preprocessing/quality_control"
     for i in $input/*_1.fq.gz;
     do
     withpath="${i}"
     filename=${withpath**#**#/}
     base="${filename%*_*.fq.gz}"
     sample_name=`echo "${base}" | awk -F ".fastq.gz" '{print $1}'`
     java -jar /home/abdulrahman/h3ameta/preprocessing/Trimmomatic-0.38/trimmomatic-0.38.jar PE -threads 6 -trimlog $output/"${base}".log $input/"${base}"_1.fq.gz  $input/"${base}"_2.fq.gz $output/"${base}"_R1.trimmed_PE.fastq $output/"${base}"_R1.trimmed_SE.fastq $output/"${base}"_2.trimmed_PE.fastq $output/"${base}"_2.trimmed_SE.fastq LEADING:3 TRAILING:3 SLIDINGWINDOW:4:15 MINLEN:20

     done
    """
    }_

Nextflow fails to recognize the highlighted # in the line starting with filename

The specific error is:
_ERROR ~ unexpected char: '#' @ line 56, column 29.
filename=${withpath##/}
^

1 error
_

@elimoss
Copy link
Contributor Author

elimoss commented Mar 13, 2019

What's the intended behavior? I'm not too sure what the # is supposed to do--is this a string operator I'm not familiar with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants