Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade glam to 0.22, bump minimum to 0.21 #12

Merged
merged 1 commit into from Oct 24, 2022

Conversation

MarijnS95
Copy link
Contributor

glam finally removed the deprecated const_vec3! macro constructor in favour of proper const fns, supported for both arrays and loose per-component arguments. This however bumps the minimum requirement to 0.21 where these const fns were first introduced, and propagates its 1.58.1 MSRV.

`glam` finally removed the deprecated `const_vec3!` macro constructor in
favour of proper `const fn`s, supported for both arrays and loose
per-component arguments.  This however bumps the minimum requirement to
`0.21` where these `const fn`s were first introduced, and propagates its
1.58.1 MSRV.
@@ -9,9 +9,10 @@ documentation = "https://docs.rs/dolly"
keywords = ["gamedev", "camera", "3d"]
categories = ["game-development"]
readme = "crates-io.md"
rust-version = "1.58.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied this from glam, but I don't recall any of the needed const machinery being introduced in that version. Regardless, dolly should probably check+enforce some MSRV in its CI (perhaps other code requires higher Rust versions already).

@h3r2tic
Copy link
Owner

h3r2tic commented Oct 24, 2022

woop woop! 🥳 thanks for the PR :) Sounds like it's time for dolly 0.4 then!
I'll look at setting up some CI at um... some point xD meanwhile, this LGTM.

@h3r2tic h3r2tic merged commit 26cab14 into h3r2tic:main Oct 24, 2022
@h3r2tic
Copy link
Owner

h3r2tic commented Oct 24, 2022

Aaaaaaand we're live with 0.4!

@MarijnS95
Copy link
Contributor Author

@h3r2tic Thanks for merging this so quickly! Do you want to set up the CI yourself, or should I cobble together various bits of CI logic from the many projects I maintain? Think about rustfmt, clippy, cargo test, cargo doc with warnings (e.g. broken intradoc links) disallowed, and the proposed MSRV build-test.

@h3r2tic
Copy link
Owner

h3r2tic commented Oct 24, 2022

Oh if you have some action configs handy, dolly (and I) would love a PR! I only have a subset of that in some of my projects 😅

@MarijnS95
Copy link
Contributor Author

@h3r2tic cool! Submitted in #13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants