Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BMP loader #21

Closed
2 tasks done
h4570 opened this issue Dec 4, 2020 · 2 comments
Closed
2 tasks done

Improve BMP loader #21

h4570 opened this issue Dec 4, 2020 · 2 comments
Labels
good first issue Good for newcomers refactor This needs to be refactored

Comments

@h4570
Copy link
Owner

h4570 commented Dec 4, 2020 •
edited

Currently BMP loader does not give any feedback about wrong file.

  • Add 24bit check
  • Add auto skipping of color information header.

tyra/src/engine/include/loaders/bmp_loader.hpp

Line 19 in d58163d

class BmpLoader

@h4570 h4570 added refactor This needs to be refactored good first issue Good for newcomers labels Dec 4, 2020
@Foxar
Copy link
Contributor

Foxar commented Apr 21, 2021

Assuming "color information header" refers to the color table just before GAP1 of the bmp file format:
I don't understand why we need to skip it, since we only permit 24bit BMP file formats, in which the color table is omitted entirely.

This was referenced Apr 21, 2021
Merged
Merged
@h4570
Copy link
Owner Author

h4570 commented May 28, 2021

Thank you @Foxar!

@h4570 h4570 closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor This needs to be refactored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Foxar @h4570