Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Restrict node engine to >= 4 #1929

Closed
amilajack opened this issue Mar 25, 2017 · 5 comments
Closed

RFC: Restrict node engine to >= 4 #1929

amilajack opened this issue Mar 25, 2017 · 5 comments

Comments

@amilajack
Copy link
Contributor

Node < 4 is deprecated.

Willing to PR for this
@roblarsen
Copy link
Member

Please PR

@amilajack
Copy link
Contributor Author

Just made the PR for this

@roblarsen
Copy link
Member

closed via #1931

Since you're involved in a few conversations right now- with the next PR that's related to an issue, you can reference the issue number directly with "closes #xxxx" in the commit message and it will:

  • show up in the comments on the issue
  • automatically close the issue when it's merged in.

@roblarsen
Copy link
Member

(and.... thanks!)

@amilajack
Copy link
Contributor Author

with the next PR that's related to an issue, you can reference the issue number

Thanks. Will make sure to do this next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblarsen @amilajack