Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Browserupgrade prompt #2210

Closed
1 of 3 tasks
coliff opened this issue Apr 11, 2020 · 0 comments · Fixed by #2218
Closed
1 of 3 tasks

Remove Browserupgrade prompt #2210

coliff opened this issue Apr 11, 2020 · 0 comments · Fixed by #2218
Milestone

Comments

@coliff
Copy link
Member

coliff commented Apr 11, 2020

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (below))

HTML5Boilerplate default HTML includes a browser upgrade prompt which only displays on IE9 and below. I suggest that this should be removed in the next version of H5BP because:

  • It doesn't display on IE10 (as IE10 doesn't support IE conditional comments)
  • An IE8 user seeing the 'upgrade your browser' link does not provide supported alternatives. Chrome/Firefox/Opera are no longer supported on XP or Vista which an IE8 user would have.
  • In my limited testing https://browsehappy.com/ doesn't actually load on IE8 anymore (HTTPS/SSL issue maybe?)
  • IE8/IE9 marketshare is tiny

Instead, it'd possibly be a better idea for developers to detect version of IE in JavaScript (possibly by detecting the version of Windows too). If user is on Windows 7 or 8 - they should update to IE11 or download Edge. I think adding info or code for this is maybe out of scope of this project though, so suggest we simply remove the browserupgrade prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants