Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that build script works following removal of JS folders #934

Closed
necolas opened this issue Jan 24, 2012 · 3 comments
Closed

Confirm that build script works following removal of JS folders #934

necolas opened this issue Jan 24, 2012 · 3 comments
Milestone

Comments

@necolas
Copy link
Member

necolas commented Jan 24, 2012

This commit removes /mylibs and /modules from /js - f6ccd10

Need to confirm that the build script is ok with this. If not, make appropriate changes.

@nimbupani
Copy link
Member

So with this removal we also no longer need files.bypass. The build script breaks unless we remove references to mylibs folder. But before I do that, here are what would happen with this change:

Previously we used to concat all scripts in mylibs folder and add it to the final script we make. We added a special file.js.bypass to allow devs to put scripts that opted out of this concat/minification. Now this is not necessary.

However, this means we no longer have an option to add scripts to concat/minification process. It will only work on script.js and plugin.js

So the question is:

  • Do we add all .js files in the js folder to the concat/minify task? If so, do we retain files.js.bypass to give the option to opt out of this?
  • Or do we not have the option at all of concat/minifying own scripts?

Paging @roblarsen.

@roblarsen
Copy link
Member

I think we go with option #1. We really need to keep the option to add scripts.

@nimbupani
Copy link
Member

Fixed by d269a55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants