Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double slash in ckeditor basePath #55

Open
yannick-t opened this issue Jul 23, 2018 · 1 comment
Open

Double slash in ckeditor basePath #55

yannick-t opened this issue Jul 23, 2018 · 1 comment

Comments

@yannick-t
Copy link

Hi,
In h5p-editor-html.js the basePath for ckeditor is set to
CKEDITOR.basePath = ns.basePath + '/ckeditor/'
which results in a double slash because basePath already has a trailing slash.
(at least in the wordpress implementation and from what I've tested it is needed for the darkroom image editor because there the path is set without an extra slash).

From what I've gathered this results in a valid url and for example in wordpress it is interpreted correctly but it does not seem to be intended.
I'm currently experimenting with a Java backend for h5p and jetty is not happy with the double slash

@thomasmars
Copy link
Member

I have transformed this into a JIRA issue where you can follow along the progress: https://h5ptechnology.atlassian.net/browse/HFP-2146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants