Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list: Add, edit, and remove functionalities #2

Merged
merged 9 commits into from Apr 27, 2022

Conversation

ha-manel
Copy link
Owner

🎯 In this branch I:

  • Added a JavaScript class for the to-do tasks in a separate file.
  • Added add , edit , and remove methods to the Tasks class.
  • Added functionality to the refresh button to reload the page upon click.

Copy link

@BenMukebo BenMukebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approve 🍾 👍 🎊

Hi @ha-manel,

Congratulations! 🎉 Project Approved ✅

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

To Highlight 🥇

  • Descriptive Pull Request 👏🏻
  • Professional README ✔️
  • A function for adding a new task has been well implemented. ✔️
  • A function for editing task descriptions has been well implemented. ✔️
  • A function for deleting a task has been well implemented. ✔️
  • All changes to the To-Do List is saved in local storage., keep rocking 🚀

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers 🥂 and Happy coding!!! 👯💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @BenMukebo when you comment so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ha-manel ha-manel merged commit 526293d into main Apr 27, 2022
@ha-manel ha-manel deleted the add-remove-functionalities branch April 27, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants