Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list: Interactive list #3

Merged
merged 9 commits into from Apr 27, 2022
Merged

To-do list: Interactive list #3

merged 9 commits into from Apr 27, 2022

Conversation

ha-manel
Copy link
Owner

🎯 In this branch I:

  • Added a status class to manipulate and update the status of the tasks.
  • Added styling to the completed tasks.
  • Added functionality to the clear completed button.

@github-pages github-pages bot temporarily deployed to github-pages April 27, 2022 15:02 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 27, 2022 17:02 Inactive
Copy link

@omar-labana omar-labana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔️

Hi @ha-manel

  • [OPTIONAL] Instead of reloading the page to rerender the task list, please set the list markup to ''' then re-invoke the render function. Your logic should consume as little resources as possible.

Congratulations on completing this project! 👏🏼 🎉

You have correctly implemented all of the requirements📃 correctly and without any errors⚠️ or bugs🪲.

Cheers and good luck in your next milestones! 🍀

Feel free to leave any questions or comments in the PR thread(don't forget to tag me 😄) if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ha-manel ha-manel merged commit a876d1c into main Apr 27, 2022
@ha-manel ha-manel deleted the interactive-list branch April 27, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants