Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morning Session Peer-to-Peer Code Review #8

Closed
kelvinbush opened this issue May 10, 2022 · 0 comments
Closed

Morning Session Peer-to-Peer Code Review #8

kelvinbush opened this issue May 10, 2022 · 0 comments

Comments

@kelvinbush
Copy link

kelvinbush commented May 10, 2022 •
edited

Good job so far here are some suggestions you could implement to improve your code:

  • You could make your code DRY by refactoring the repeated lines of code in the task.js file, check this line it is repeated multiple times.
  • It is better if you could change the color of the focused input for better UX.
  • You could unmark a task as completed when the user edits a completed task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelvinbush @ha-manel