Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styles to the Dragons section #53

Merged
merged 4 commits into from Jun 16, 2022
Merged

Added styles to the Dragons section #53

merged 4 commits into from Jun 16, 2022

Conversation

rskinnerc
Copy link
Collaborator

In this PR I have added some desktop and mobile styles to the Dragons section

In this PR I have:

  • Added desktop styles to the Dragon component
  • Added mobile styles to the Dragon component
  • Moved the font family import to the global namespace (App.css)
  • Fixed linter errors

Copy link
Collaborator

@Danie12345 Danie12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✅🤑🤑

Hi @rskinnerc 👋

Good job implementing the requested changes!

There's nothing else to say other than it's time to MERGE it! :D

To Highlight 🎉

  • No linter errors. ✔️
  • GitHub flow is followed. ✔️
  • Good commit messages. ✔️
  • PR has a good description and title ✔️

Required Changes ♻️

  • None! :D

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Danie12345 Danie12345 merged commit d55f21e into dev Jun 16, 2022
@Danie12345 Danie12345 deleted the style-dragons branch June 16, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants