Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election: Don't send election messages without quorum #5893

Open
baumanj opened this issue Nov 29, 2018 · 3 comments
Open

Election: Don't send election messages without quorum #5893

baumanj opened this issue Nov 29, 2018 · 3 comments
Labels
Focus:Gossip Protocol Tasks related to fundamental gossip algorithm behavior Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Bug Issues that describe broken functionality Type:BugFixes PRs that fix an existing bug

Comments

@baumanj
Copy link
Contributor

baumanj commented Nov 29, 2018

In elections we have the concept of quorum as defined by the butterfly server's check_quorum method. Functionally, it means that enough of the supervisor nodes we know about are healthy such that we can have an election without fear of getting into a split-brain scenario.

However, because quorum is based on the membership protocol and the membership protocol is subject to seeing other nodes as unhealthy due to network congestion, it can be hard to complete an election when the network is congested. Unfortunately adding the election messages into the mix makes congestion worse.

Currently, an election can't finish without quorum, but otherwise the lack of quorum has no effect on how elections run. To avoid unnecessary work that may worsen congestion, we should investigate the possibility of only initiating (and possibly propagating) election messages when there is quorum.

@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Apr 2, 2020
@christophermaier christophermaier added Type:BugFixes PRs that fix an existing bug and removed X-fix labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Bug Issues that describe broken functionality and removed A-supervisor labels Jul 24, 2020
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

1 similar comment
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Gossip Protocol Tasks related to fundamental gossip algorithm behavior Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Bug Issues that describe broken functionality Type:BugFixes PRs that fix an existing bug
Projects
None yet
Development

No branches or pull requests

4 participants