Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Supervisor filesystem pathing code #5931

Open
christophermaier opened this issue Dec 6, 2018 · 2 comments
Open

Consolidate Supervisor filesystem pathing code #5931

christophermaier opened this issue Dec 6, 2018 · 2 comments
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance Type:Technical Debt No functional changes; just about cleaning up and reorganizing

Comments

@christophermaier
Copy link
Contributor

We have code for determining the appropriate filesystem paths for several parts of the Supervisor, split across several locations. For consistency, we should consolidate all these.

For example:

  • FsCfg (if we consolidate to pure functions, it's not clear that we even need FsCfg).
  • sup_protocol::sup_root (Not sure why this is in sup_protocol; also, the custom_state_path argument of this function is only used in tests, which ends up needlessly cluttering our real code)
  • hab_sup::fs

There may be additional places where things could be consolidated; this is just from a cursory survey.

Note that there is also a core::fs module that has some similar functions; these should deal with non-Supervisor filesystem paths, though. We should base this refactoring on that module where appropriate, but endeavor to keep it restricted to purely Supervisor concerns.

@christophermaier christophermaier added A-supervisor Type:Technical Debt No functional changes; just about cleaning up and reorganizing labels Dec 6, 2018
@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Apr 3, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component and removed A-supervisor labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance Type:Technical Debt No functional changes; just about cleaning up and reorganizing
Projects
None yet
Development

No branches or pull requests

2 participants