Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hab studio -q leaks origin key operation output to STDOUT #5946

Open
themightychris opened this issue Dec 8, 2018 · 5 comments
Open

hab studio -q leaks origin key operation output to STDOUT #5946

themightychris opened this issue Dec 8, 2018 · 5 comments
Labels
Stale Type: Bug Issues that describe broken functionality

Comments

@themightychris
Copy link
Contributor

The -q option to hab-studio is advertised as suppressing hab output so you can get the output of the command, but currently fails to suppress 4 lines about origin keys, and there is no way to disable key import entirely via -k:

hab studio -q -t busybox run ls -l /
» Importing origin key from standard input
★ Imported secret origin key jarvus-20170820000144.
» Importing origin key from standard input
★ Imported public origin key jarvus-20170820000144.
total 52
drwxr-xr-x   2 root root 4096 Dec  8 17:19 bin
drwxr-xr-x  22 root root 4560 Dec  7 16:16 dev
drwxr-xr-x   2 root root 4096 Dec  8 17:49 etc
drwxr-xr-x   7 root root 4096 Dec  8 17:19 hab
drwxr-xr-x   3 root root 4096 Dec  8 17:19 home
drwxr-xr-x   2 root root 4096 Dec  8 17:49 lib
lrwxrwxrwx   1 root root    3 Dec  8 17:18 lib64 -> lib
drwxr-xr-x   2 root root 4096 Dec  8 17:18 mnt
drwxr-xr-x   2 root root 4096 Dec  8 17:18 opt
dr-xr-xr-x 592 root root    0 Nov  7 02:51 proc
drwxr-x---   2 root root 4096 Dec  8 17:20 root
drwxrwxrwt   2 root root   40 Dec  8 17:49 run
drwxr-xr-x   2 root root 4096 Dec  8 17:18 sbin
drwx--x--x  15 1000 1000 4096 Dec  8 08:01 src
dr-xr-xr-x  13 root root    0 Dec  8 17:26 sys
drwxrwxrwt   2 root root 4096 Dec  8 17:46 tmp
drwxr-xr-x   8 root root 4096 Dec  8 17:18 usr
drwxr-xr-x  11 root root 4096 Dec  8 17:18 var

When run without -q, the same command prints additional lines related to the leaked lines, so this seems to confirm it is a mistake for the nested command output to be passing through:

hab studio -t busybox run ls -l /
   hab-studio: Creating Studio at /hab/studios/mnt--chris-backup (default)
   hab-studio: Importing 'jarvus' secret origin key
» Importing origin key from standard input
★ Imported secret origin key jarvus-20170820000144.
   hab-studio: Importing 'jarvus' public origin key
» Importing origin key from standard input
★ Imported public origin key jarvus-20170820000144.
   hab-studio: Running 'ls -l /' in Studio at /hab/studios/mnt--chris-backup (default)
@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Apr 2, 2020
@christophermaier christophermaier added Type: Bug Issues that describe broken functionality and removed C-bug labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@stale
Copy link

stale bot commented Jul 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jul 25, 2021
@themightychris
Copy link
Contributor Author

this is still an issue

@stale stale bot removed the Stale label Jul 25, 2021
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

1 similar comment
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Type: Bug Issues that describe broken functionality
Projects
None yet
Development

No branches or pull requests

2 participants