Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for easier modification of log4rs-based logging #6586

Open
christophermaier opened this issue May 23, 2019 · 3 comments
Open

Allow for easier modification of log4rs-based logging #6586

christophermaier opened this issue May 23, 2019 · 3 comments
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance

Comments

@christophermaier
Copy link
Contributor

christophermaier commented May 23, 2019

As a follow-on to #6583, if we decide to continue to allow logging modification through environment variables, we should also deprecate RUST_LOG in favor of HAB_LOG (the fact that Habitat is written in Rust shouldn't matter to users, and the HAB_ prefix is consistent with our other environment variables).

We will need to iron out exactly how this would interact with a configuration file. Would it take priority over the file, or would the file take priority over it (particularly since the latter can be modified at runtime, but the former cannot)? Would the environment variable configuration be merged with anything in a file? Should the environment variable continue to contain a limited subset of logging configuration (consistent with its previous env_logger use), or would we want to do something like accept the contents of the variable as a valid log4rs YAML file?

@christophermaier
Copy link
Contributor Author

Alternatively, we could look at this as providing some basic log configuration functionality in Habitat's own terms (independent of any underlying logging system implementation). "Power users" that are willing to dig into implementation-specific details would still be free to manipulate their own log4rs configuration file, recognizing that that is not necessarily an interface contract that we will always provide.

@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jun 5, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance and removed A-supervisor labels Jul 24, 2020
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

No branches or pull requests

2 participants