Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the use of tokio-trace for internal Supervisor Logging #6625

Open
christophermaier opened this issue Jun 6, 2019 · 3 comments
Open
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale

Comments

@christophermaier
Copy link
Contributor

tokio-trace is a (very) new library for scoped, structured logging and diagnostics in async programs. Despite its name, it is not Tokio-specific, but does serve an important need in the Tokio ecosystem (namely, helping figure out what's going on in heavily-futures-based systems where tasks can get passed around to many threads in the course of execution).

This talk on Youtube provides a useful overview.

The ability to add scoped, structured logs will be a huge win (I experimented briefly with log_mdc for this, but it's not a great fit with futures... it's really more for situations where you have a dedicated thread-per-task structure). Being able to correlate information across the entire execution of a future is also going to be incredibly useful for debugging, monitoring, etc.

Once we have consolidated all our output under the common log interface (see #6584), we could begin to experiment with tokio-trace. I think there may be some "glue" that will need to be written to help make log4rs be an output destination for tokio-trace, so that will need to be investigated as well.

@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jun 5, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component and removed A-supervisor labels Jul 24, 2020
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Aug 13, 2022
@stale
Copy link

stale bot commented May 22, 2023

This issue has been automatically closed after being stale for 400 days. We still value your input and contribution. Please re-open the issue if desired and leave a comment with details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale
Projects
None yet
Development

No branches or pull requests

2 participants