Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Default Implementation for PackageIdent #6829

Closed
davidMcneil opened this issue Aug 9, 2019 · 3 comments
Closed

Remove Default Implementation for PackageIdent #6829

davidMcneil opened this issue Aug 9, 2019 · 3 comments
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Feature Issues that describe a new desired feature

Comments

@davidMcneil
Copy link
Contributor

davidMcneil commented Aug 9, 2019 •
edited

The Default PackageIdent is an empty origin and name. This is dangerous and could lead to bugs. We should remove the Default implementation and verify that a PackageIdent is always valid.
@smacfarlane
Copy link
Contributor

Ref: #6276

@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Feature Issues that describe a new desired feature and removed A-supervisor labels Jul 24, 2020
@rahulgoel1 rahulgoel1 removed the L-rust label Jul 23, 2021
@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Oct 1, 2022
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically closed after being stale for 400 days. We still value your input and contribution. Please re-open the issue if desired and leave a comment with details.

@stale stale bot closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Feature Issues that describe a new desired feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smacfarlane @christophermaier @davidMcneil @rahulgoel1