Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round Boss health up, not to nearest integer #2504

Closed
colegleason opened this issue Jan 21, 2014 · 1 comment
Closed

Round Boss health up, not to nearest integer #2504

colegleason opened this issue Jan 21, 2014 · 1 comment

Comments

@colegleason
Copy link
Contributor

A user in Tavern reported that the boss said it was at 0 HP but the quest wasn't complete. I think this might be because he has like .2 HP but that rounds down on the display to 0 HP.

This is the offending line, just need to make sure that it isn't used elsewhere: https://github.com/HabitRPG/habitrpg-shared/blob/develop/script/index.coffee#L191

Maybe we can add a roundDirection arg.
@colegleason
Copy link
Contributor Author

Had to revert. Will revisit when I have time.

@colegleason colegleason reopened this Jan 25, 2014
@wc8 wc8 added the interface label Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colegleason @crookedneighbor @wc8