Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement local storage handling #19

Open
marzavec opened this issue Dec 14, 2020 · 4 comments
Open

Implement local storage handling #19

marzavec opened this issue Dec 14, 2020 · 4 comments
Labels
high priority Gotta get on this missing feature A feature that should be added to the client

Comments

@marzavec
Copy link
Member

Local storage should be used to save the users nick and password, along with other settings ( #12 ). This data should be loaded into the redux store when the app starts. This may also tie into #6

@marzavec marzavec added missing feature A feature that should be added to the client high priority Gotta get on this labels Dec 14, 2020
@henrywright
Copy link

The data in local storage could be accessed by different users if the computer is shared. How can we ensure the sensitive portion of the stored data is cleared when a user is finished using hack.chat?

@marzavec
Copy link
Member Author

I have seen this concern raised a few times in the past, because this is the same behavior that the legacy client uses. There are very few options available to address the concern. Do you have any suggestions?

@henrywright
Copy link

henrywright commented Dec 15, 2020

In my opinion I wouldn't store sensitive information in local storage but if the legacy client does this currently then we could implement a clearing mechanism to ensure the data is deleted

The data could be automatically deleted when the user closes hack.chat or alternatively a button could be provided for the user to click. I'm not sure which approach is best. What are your thoughts?

@marzavec
Copy link
Member Author

Since this is a different issue, I've opened up a different case, #28 where we can discuss it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Gotta get on this missing feature A feature that should be added to the client
Projects
None yet
Development

No branches or pull requests

2 participants