Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with React version below 0.13.0 #134

Closed
raorao opened this issue Jul 9, 2015 · 4 comments
Closed

incompatible with React version below 0.13.0 #134

raorao opened this issue Jul 9, 2015 · 4 comments

Comments

@raorao
Copy link

raorao commented Jul 9, 2015

attempting to load, I get the following error:

Uncaught TypeError: React.findDOMNode is not a function

The findDOMNode API was introduced in React 0.13, which is the root cause of the problem. I'd be happy to put in a fix, although perhaps the library is meant not to support older versions of React. interested to hear your thoughts.

@raorao raorao changed the title incompatible with React v0.12.0 incompatible with React version below 0.13.0 Jul 9, 2015
@martijnrusschen
Copy link
Member

Hi @raorao. This is something that was added in React 0.13. We're happy to support merge a PR that adds backward compatibility of the React 0.12 behaviour, but be aware that React is still in beta and you will continue having breaking changes until React hits 1.0.

@brianjmcneely
Copy link

As a related question, is there anything in React 0.14 that breaks this component? Just looking at what versions of React it allows in the package.json and wondering why. Regardless, it probably shouldn't allow versions below 0.13 if the error that @raorao mentioned is occurring on those versions.

@martijnrusschen
Copy link
Member

I haven't tried it yet, but I'm happy to merge a PR that ups the React version :)

@martijnrusschen
Copy link
Member

This works with 0.14 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants