-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Password Generator #22
Comments
@umitseyhan75 Of course, I can do that! I'll put that on the list of to-dos for v1.15, which also includes localization support. v1.14 is almost finished and once released, I'll get started on localization and a password generator. Thanks for the request! |
@umitseyhan75 The password generator has been implemented in v1.15. Can you give it a try and let me know your thoughts? Thanks! |
Hi @umitseyhan75, not a problem at all, I can do that! I'll just make the "Generate" button open a modal and there, you can tick checkboxes to toggle lowercase letters, symbols, etc. I'll post a screenshot when I have it ready :) |
Also, I suggest you to find an eye icon svg (with matcihng colours of ui) and put it at the far right end of password box as a button to funciton as "show/hide" password. |
@umitseyhan75 Try out the file attached and let me know what you think of the password generator. Thank you! |
I do not see any diffrence. Are you sure this not the same file? I mean normal 1.15. |
Hmm? My bad! Here's the correct one. (Don't worry about the big file size, this is just a test version) |
Yeap, that is better! But still needs improvement. Especially password length. |
Great to hear! Can you list all the improvements you would like to see so that I have a guideline? |
Okay, here are the first things that comes to my mind. Cosmetic
Functional
Here I prepared some: eye-icon.zip
|
For the Cosmetics section, it would be quite difficult to implement your suggestions, because Picocrypt' UI library, giu, is rather minimal. Go is a very new language itself, and it's primarily used for servers, so frontend development is an even newer topic, which is why there doesn't exist a very good UI library for Go right now. For 1, 2, and 3, there's unfortunately nothing I can do. They're great points, but I don't think it's possible to do with giu. For 4, I'll fix it right away. The copy I sent you was right after implementing the generator, and I didn't adjust the layout yet. For the show password button, I would be happy to do it, but again, it seems that there is no native SVG support in Go, and no support either in giu. The best I can do is use a PNG, but I'm not sure if it would scale properly. I'll need to look into this more and hopefully I will be able to do this. The password length selector is trivial to do, so I will get to that right away. The Minimum/Exactly dropdown is a interesting idea, but why would you need varying lengths? For example, if you set a minimum of 5 characters and a 7 character password is generator, you could just set it to generate exactly 7 digits. Is there a special use case for this that I don't know about? For your last point, no problem. I'll add the option to copy to clipboard automatically and saving the password to a text file should be simple as well. But I don't think it's possible to set the system to auto clear the clipboard after some time interval without a constant process running in the background. I'll get to work right away! |
BTW, I've started on a new homepage which will be https://evansu.cc/picocrypt. Right now, there's nothing, but I do have a preview of what I have so far: https://picocrypt.netlify.app/. I only spent like 20 mins on it as of now, so it doesn't have much. But it would be nice to have some feedback on what I have so far. So, what do you think of it so far? |
That is sad to be honest.
You can export it at any size you want to PNG.
I do not understand your example very much. You mean the generator you implemented supports 7 character for minimum amount?
That is unfortune.
I do belive Picocrypt needs a web site. But I do not think this issue is not the place to talk about it. |
Now that I've thought about it again and the lowercase may need to removed from there. The Minimum and Exactly selections for numbers, symbols and uppercases. Those numbers on paint reference are just random numbers for showing purpose. Let's say I selected password lenght to 20 and "Exactly" option and put 2 to the symbols and all others are 1 (can not be zero on Exactly anyway). In this case the password will have exactly 2 symbols, 1 digit and 1 uppercase nothing more nothing less. all other should be lowercase letters. Besides those amounts can't be more than total lenght. |
Oh, I see what you mean, and I totally see why that would be useful. Although since Picocrypt is meant to be relatively simple, a scenario like that would be a bit overkill. I think the current setup, where you choose a length and toggle the sets of characters you would like, is the best fit. Simple enough not to confuse a user (I was a little confused until you described it), but customizable enough to choose a secure password. So in line with Picocrypt's ideology, I don't think it's necessary to go this far. Although I do thank you very much for suggesting togglable sets of characters. |
Well then, that is something after all! |
I don't know if it is possible or not but, the password lenght section can be color filled (light blue) depending on the lenght. |
Btw that is exactly what I had in my mind for the eye icon. Reference: Send |
Your first point about the solid slider isn't possible as far as I know, but the second might be possible. I won't dive deep into it right now, as I have many other things to get to, but it might be something I'll add in v1.17 or later. |
The password generator is complete, and since it has some customizability and aligns with Picocrypt's ideology, I think I won't be changing it in the future. So I'll be closing this issue. |
A button right side of password entered area named "generate" would be pretty usefull.
Ideally I would suggest implement Bitwarden's generator.
And some optional checkboxes like "copy the generated password to the clipboard" or "remove the password from the clipboard after x time passed" or "save the generated password to a text file where the encrypted files will be located".
The text was updated successfully, but these errors were encountered: