Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrypting to C:\Program Files\ does nothing → confusion (admin permission) #40

Closed
Inrumpo opened this issue Sep 22, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Inrumpo
Copy link

Inrumpo commented Sep 22, 2021

I'm currently testing Picocrypt because I like the idea and functionality behind this lightweight tool. I believe my rather "non-techy" perspective can be of value (in terms of expectations and workflow).

Environment

  • Windows 10, 64bit
  • Version 1.17 stable

Description of the issue

Decrypting a .pcv file located at C:\Program Files\Picocrypt to the same destination (probably anywhere in C:\Program Files\) does nothing if Picocrypt.exe isn't running with administrator permission.

Picocrypt decrypting issue

This is not a bug, rather a Windows security feature. The user (not knowing this) might be confused because nothing happened; especially after getting the green Completed. message.

Possible solution

Is it possible to show a hint or even prompt the user to grant administrator permission when decrypting to a "protected" destination?

@HACKERALERT
Copy link
Owner

Great catch! I should be able to detect this with a pretty trivial fix. I don't think Go allows to me automatically prompt for permissions, so I guess the user would have to restart Picocrypt. But I will definitely add the hint that there was a permission issue!

@HACKERALERT HACKERALERT self-assigned this Sep 22, 2021
@HACKERALERT HACKERALERT added enhancement New feature or request in progress Work is in progress labels Sep 22, 2021
@HACKERALERT
Copy link
Owner

The issue should be fixed now. Can you confirm that the attached version detects the permission issue on your system? Thanks!
Picocrypt.zip

@Inrumpo
Copy link
Author

Inrumpo commented Sep 22, 2021

Can you confirm that the attached version detects the permission issue on your system?

There are multiple combinations possible:

  • Decrypting a folder from outside into C:\Program Files\Picocrypt shows a permission error by Windows. ✔

  • Encrypting a folder from outside into C:\Program Files\Picocrypt shows a permission error by Windows. ✔

  • Decrypting a folder from C:\Program Files\Picocrypt to C:\Program Files\Picocrypt shows a new error message by Picocrypt. ✔

  • Encrypting a folder from C:\Program Files\Picocrypt to C:\Program Files\Picocrypt is not possible. Picocrypt crashes (= same behavior as 1.17). ❌

@HACKERALERT
Copy link
Owner

Thanks. I'll fix the last case soon!

@HACKERALERT
Copy link
Owner

I put checks on both the input file and output file, so the issue is fixed now :)

@HACKERALERT HACKERALERT removed the in progress Work is in progress label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants