Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come the compiled version has more features than the source code? #22

Open
benelot opened this issue May 8, 2019 · 2 comments
Open

Comments

@benelot
Copy link

benelot commented May 8, 2019

I could at least spot that the compiled version has the instrument buttons. Also, would you mind releasing the model?

@HackerPoet
Copy link
Owner

Yeah, the compiled version is a C++ port of the python one with just a few small differences like the instrument button.

I usually don't release pre-trained models for a few reasons:

  • My C++ framework is custom-built and the models are not really compatible with existing tools
  • I don't really have time to document the data format and usage
  • The original models are really large (in this case 350MBs) and I don't have a good place to host it
  • There could be privacy or ownership issues depending on the data used
  • I don't want the pre-trained models to be used commercially (code is MIT licenced though)

Hopefully it should not be too hard to train a similar model yourself with the code provided.

@benelot
Copy link
Author

benelot commented May 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants