Add "pause" menu #583
Draft
Add "pause" menu #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
force-pushed
the
feature/pause-menu
branch
from
2f3b51f
to
27512a3
Compare
toberge
force-pushed
the
feature/pause-menu
branch
3 times, most recently
from
4f45ec5
to
b93aa5b
Compare
Fueredoriku
requested changes
Mar 17, 2024
There was a problem hiding this comment.
Good feature! 😁👍
I have some feedback and one requested change:
Feedback:
- I think we should rename the "Not paused" title to just "Menu" or "Pause Menu"
- The keybind for the gamepadaction of opening the menu should probably be mapped to the right button and not the left. Whic would be "start[gamepad]" instead of "exit[gamepad]". Alternatively it could be both.
Requested change:
- Currently the pause menu breaks zooming. If zooming is performed and the player then pauses and continues the game, zooming will remain broken until player is respawned.
toberge
force-pushed
the
feature/pause-menu
branch
from
1421c56
to
08969fd
Compare
|
Fixened |
toberge
force-pushed
the
feature/pause-menu
branch
from
08969fd
to
13c15cb
Compare
toberge
force-pushed
the
feature/pause-menu
branch
from
13c15cb
to
d51ee20
Compare
Fueredoriku
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Some feedback:
- It seems you can't select between buttons with a gamepad
- Opening more than one menu will deselect all buttons for all players except the newest menu
And a bit more nickpicky:
- For gamepads specifically: When zoomed, if you open a menu, the hand will remain in zoomed position until you zoom in and out again (I suspect this is due to gamepads having toggle behaviour for zooming that is not accounted for)
Merged
|
Setting this as draft again since it's waaaay more work than I assumed 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barely solves #138
Closes #586
Closes #585