Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2 GetPasswordResetEmail expects user to provide their ID #138

Open
kzalys opened this issue Oct 19, 2020 · 1 comment
Open

API v2 GetPasswordResetEmail expects user to provide their ID #138

kzalys opened this issue Oct 19, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers technical-debt

Comments

@kzalys
Copy link
Collaborator

kzalys commented Oct 19, 2020

Currently the GetPasswordResetEmail operation on API v2 expects the user to provide their ID in the request. If the user wants to reset their password, they probably cannot login and if they cannot login, they probably don't know their ID.

The operation should be updated to expect the user's email instead of their ID.

@kzalys kzalys added the bug Something isn't working label Oct 19, 2020
@kzalys kzalys added the good first issue Good for newcomers label Oct 27, 2020
@kzalys
Copy link
Collaborator Author

kzalys commented Oct 27, 2020

The route definition for the GetPasswordEmail operation: https://github.com/unicsmcr/hs_auth/blob/master/routers/api/v2/router.go#L80
The implementation: https://github.com/unicsmcr/hs_auth/blob/master/routers/api/v2/users.go#L370

To resolve this issue we'd need to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant