Modularization and customization #11
Conversation
… IQAudioRecorderController. This way the encapsulation inside an UINavigationController isn't forced and one is free to use an already available UINavigationController. Added class method embeddedIQAudioRecorderControllerWithDelegate: to keep the convenience.
…r because it's not internal anymore.
…hod to be safe from naming collisions.
…tic selection. This way it's easier for user to run the demo project.
…e property instead to make it possible to set a custom title from the outside.
…makes it unnecessary to keep a reference to the button.
…the demo project.
|
Thanks for pull request. Will take a look. :) |
…ctive audio session category only on init and dealloc.
…n instant response.
…them in a subclass.
|
I'm not sure if anything breaks with these huge changes. |
|
Well, you never know if anything broke ;-). I think if your applications using |
|
I think I need to look deeply inside your code and your changes before merging it. According to me it's an improvement, but need to look if this fit according to user requirement. |
|
All right. Give me a shout, if you think something needs further improvement. |
…ontroller without IQAudioRecorderViewController.
|
As you can see I further modularized the code and extracted as much functionality as possible from the view controller into other classes. Now it's possible to easily create a custom view controller as audio recorder for all those cases where it's necessary to have another view controller superclass than Please let me know what you think about this. Do you generally agree to this approach and intend to merge this? Otherwise I'll stop spamming this PR, just keep my fork and rename the lib. Thanks, Seb |
|
Hey @sebastianludwig I'll check your repo code and will let you know If I'm good to go with your changes or not. |
|
👍 |
… errors (coming soon).
…and IQAudioRecorderViewController.
…RecorderController.
…t as easy as possible for everyone to run the sample project on a device.
… to didFinishPlayback to sound more like typical iOS methods.
… deletion to get rid of Xcode warning (if possible).
|
Hi Sabestian, I found that you did a good refactoring. Thank You! I'm happy to merge your changes. However this PR can't e merged automatically, I'll extract useful code according to my requirement from your repo and will merge manually. Thank You again! |
|
All right. Please let me know when you're done so I can se if I can switch back to your repo and ditch my fork. Thanks! |
I'm planning to use your IQAudioRecorderController in my new app. That app has already a UINavigationController in place and I wanted to push the recorder onto it instead of presenting it modally.
I implemented that change and, while on it, tweaked a bit here and there.
What do you think?