Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird new API with exposed disabledDistanceHandlingClasses property #516

Closed
DivineDominion opened this issue May 23, 2016 · 3 comments
Closed
Labels

Comments

@DivineDominion
Copy link

DivineDominion commented May 23, 2016

Instead of a method on IQKeyboardManager that hides implementation details users are now encouraged to violate the object's boundaries and mutate one of its properties directly with IQKeyboardManager.sharedManager().disabledDistanceHandlingClasses.addObject(...).

I would understand the other way 'round, but what's the rationale behind this move?

@hackiftekhar
Copy link
Owner

I exposed those properties because I found it's easy to manage.

@DivineDominion
Copy link
Author

On the client side or on the library's?

On 24 May 2016, at 08:27, Mohd Iftekhar Qurashi notifications@github.com wrote:

I exposed those properties because I found it's easy to manage.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@hackiftekhar
Copy link
Owner

Both side, but more on the library's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants