Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause and Resume #14

Closed
Khachatour opened this issue Jun 27, 2017 · 6 comments
Closed

Pause and Resume #14

Khachatour opened this issue Jun 27, 2017 · 6 comments

Comments

@Khachatour
Copy link

Hey there!! I am know deeply into your code, and trying to find possible ways to pause and resume recording. Do you have any suggestions on how I can achieve this ?

@hackingbeauty
Copy link
Owner

hackingbeauty commented Jul 5, 2017

ReactMic takes a "record" prop. When the record prop is set to true, the recording begins. When the record prop is set to false, the recording stops.

<ReactMic
  record={true || false}
/>

@Khachatour
Copy link
Author

@hackingbeauty the thing is that it stops, not paused, I did some refactoring and added, pause and resume in reactmic.js and in MicrophoneRecorder also, and managed to get context canvas and audio player pause and resume. You can't just pause with setting record props to false, it stops recording not pausing :)

@hackingbeauty
Copy link
Owner

Hi Khachatour, can you submit a PR which include your changes? I'd love to see them. Thank you!

@Khachatour
Copy link
Author

Yes of course, I can do that today by evening okay ?

@hackingbeauty
Copy link
Owner

No rush!! :)

@dprabu17
Copy link

Yes of course, I can do that today by evening okay ?

@Khachatour Please share your suggestions on how to do pause/resume recording?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants