Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Amset class into separate subclasses #38

Closed
utf opened this issue Oct 24, 2018 · 0 comments
Closed

Refactor Amset class into separate subclasses #38

utf opened this issue Oct 24, 2018 · 0 comments

Comments

@utf
Copy link
Member

utf commented Oct 24, 2018

Currently, the Amset class is very monolithic, with the core.py file running to almost 4,000 lines of code. To improve maintainability, I think it would be good to refactor out bits of the class into separate subclasses.

Initially, I think the plotting and io functions are ideal candidates for refactoring. We could do what pymatgen and other packages do, and just have an AmsetPlotter class that takes the Amset class as an initialization parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant