You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the Amset class is very monolithic, with the core.py file running to almost 4,000 lines of code. To improve maintainability, I think it would be good to refactor out bits of the class into separate subclasses.
Initially, I think the plotting and io functions are ideal candidates for refactoring. We could do what pymatgen and other packages do, and just have an AmsetPlotter class that takes the Amset class as an initialization parameter.
The text was updated successfully, but these errors were encountered:
Currently, the
Amset
class is very monolithic, with thecore.py
file running to almost 4,000 lines of code. To improve maintainability, I think it would be good to refactor out bits of the class into separate subclasses.Initially, I think the plotting and io functions are ideal candidates for refactoring. We could do what
pymatgen
and other packages do, and just have anAmsetPlotter
class that takes theAmset
class as an initialization parameter.The text was updated successfully, but these errors were encountered: