Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #782

Closed
janosh opened this issue Aug 24, 2023 · 1 comment · Fixed by #783
Closed

New release #782

janosh opened this issue Aug 24, 2023 · 1 comment · Fixed by #783
Assignees
Labels
pkg Package version-related issues

Comments

@janosh
Copy link
Member

janosh commented Aug 24, 2023

Current release fails with

atomate/vasp/drones.py:19
     17 from monty.io import zopen
     18 from monty.json import jsanitize
---> 19 from monty.os.path import which
     20 from pymatgen.apps.borg.hive import AbstractDrone
     21 from pymatgen.command_line.bader_caller import bader_analysis_from_path

ImportError: cannot import name 'which' from 'monty.os.path'

which was removed from monty a long time ago in favor of shutil.which. The main branch no longer imports it from monty but the last release from Feb 2022 still does.

@janosh janosh added the pkg Package version-related issues label Aug 24, 2023
@Zhuoying
Copy link
Contributor

@janosh Thanks for the reminder. Yeah, we will need a new release soon for all PRs merged recently and compatibility with up-to-date pymatgen, custodian, etc.

@janosh janosh self-assigned this Aug 25, 2023
@janosh janosh mentioned this issue Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg Package version-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants