New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in import composition #919
Comments
Hey @Pangcheng520 , this seems to be an issue caused by the latest version of Pymatgen which released last Saturday. To resolve this issue, |
Yeah, unfortunately there is no-one really keeping matminer up to date with its various dependencies anymore (see also #910, #915, #918) -- I tried a bit last year but hit some roadblocks in #912. However, the pinned dependencies in the various Quite a few people are running into this so any volunteers to help out would be great! |
I see. Yeah, that's a bit sad. (Automatminer is even more broken.) Happy to help keeping it updated but, of course, help from a maintainer is needed to make this work... |
Tagging @naik-aakash and @kaueltzen as they use matminer still quite a lot. |
Hi @JaGeo, I do have maintainer rights here so can merge PRs and make releases, I just don't have any real bandwidth to finish off the fixes related to #912 and the upgrade of pandas. We are still using matminer a little bit too but this is not a dealbreaker for us. I'm happy to review PRs and make releases (and can be very proactive on this) but do not want to commit my time to making fixes forever; I think perhaps this repo should be much more aggressively pinned going forwards, and then people that want to use the latest pymatgen/pandas versions with it will have to contribute it themselves. So, for now, I think this issue is closed by your PR at #920 but this cannot come into effect until the next matminer release, which is currently blocked by pandas 2 support that breaks certain featurizers. The best approach here may just be to deprecate the featurizers that are failing and skip their tests, if no-one can fix it -- there has never been a guarantee that matminer featurizers don't change value between versions anyway but currently the failures produce all NaNs, e.g., the RDF featurizer. |
For ongoing discussion of how to deal with this: #915 (comment) |
I got an error while typing the following codes:
from matminer.featurizers.base import MultipleFeaturizer
from matminer.featurizers.import composition as cf
The error reported is: ValueError: Unexpected atomic number Z=119
Was it some kind of operator error on my part? Or is there an error in matminer?
Error in import composition.docx
The text was updated successfully, but these errors were encountered: