Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login by GitHub token #412

Closed
DoneSpeak opened this issue Apr 11, 2020 · 3 comments
Closed

Login by GitHub token #412

DoneSpeak opened this issue Apr 11, 2020 · 3 comments
Milestone

Comments

@DoneSpeak
Copy link

I think it would be safer to allow the client to login with Github token instead of redirect to Github page to ask user to login with their GitHub account.

@hackjutsu hackjutsu changed the title Should provide a Github Token way to sign in Github. Login by GitHub token Apr 13, 2020
@GabrielNicolasAvellaneda
Copy link
Contributor

GabrielNicolasAvellaneda commented Apr 28, 2020

@hackjutsu hackjutsu added this to the 2.x milestone Nov 27, 2020
@Spreeuw
Copy link

Spreeuw commented Mar 4, 2021

@hackjutsu I was looking at the code and it seems that internally the app is already using access tokens, is that correct? Would it be difficult to let the user choose between entering the access token or logging in? It would be quite useful because it would allow multiple people from a team access a single gist account without needing to share the login (which is against Github terms of service and can get you banned).

@hackjutsu hackjutsu modified the milestones: 2.x, 1.9.x Jun 12, 2021
@hackjutsu
Copy link
Owner

64b8d90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants