Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file name #639

Merged
merged 2 commits into from Aug 14, 2019
Merged

Change file name #639

merged 2 commits into from Aug 14, 2019

Conversation

alinastarkov
Copy link
Contributor

Closes #422

Renamed files name to be the same as components names.
Renamed components files to be [X]Container for consistency.

erickzhao
erickzhao approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds properly, consistency lgtm :shipit:

@erickzhao erickzhao merged commit 3aa3f1c into master Aug 14, 2019
@erickzhao erickzhao deleted the change-file-name branch August 14, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@pierreTklein pierreTklein Awaiting requested review from pierreTklein

@loreina loreina Awaiting requested review from loreina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File name should be same as Component name
2 participants
@alinastarkov @erickzhao