Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: associate timeseries to different plots. #99

Closed
ubaldot opened this issue Mar 8, 2024 · 12 comments
Closed

[New Feature]: associate timeseries to different plots. #99

ubaldot opened this issue Mar 8, 2024 · 12 comments

Comments

@ubaldot
Copy link

ubaldot commented Mar 8, 2024

It would be nice to associate timeseries to graphs and have the opportunity to display multiple graphs at the same time.

For example, by assuming to receive data streams from three sensors, one should be able to plot sensorValues1 and sensorValues2 on the first graph and sensorValues3 on the second graph.

@ubaldot ubaldot changed the title [New Feature]: associated timeseries to different plots. [New Feature]: associate timeseries to different plots. Mar 8, 2024
@hacknus
Copy link
Owner

hacknus commented Mar 8, 2024

Hi, thanks for checking in!

If I understand you correctly this is possible in the latest version. you can increase the number of plots and then just select sensorValue1, sensorValue2 in the legend on plot 1, and sensorValue3 on plot 2 and so on...

I haven't gotten around to create a new release since this has been added, so you have to pull the master branch and compile it yourself for the new features.

@ubaldot
Copy link
Author

ubaldot commented Mar 8, 2024

Awesome! But tbh I don’t feel like to compile, I will wait the release for apple silicon. :)

@hacknus
Copy link
Owner

hacknus commented Mar 8, 2024

fair enough! now I have a motivation to push for a release! I'll look into it as soon as I can!

@ubaldot
Copy link
Author

ubaldot commented Mar 8, 2024

Infinitely thanks! The possibility of associating timeseries to graphs would be a killer feature that I haven't seen in any other project. Please, close this issue once done so that I get notified. :) Thanks again!

@hacknus
Copy link
Owner

hacknus commented Mar 9, 2024

@ubaldot enjoy:
https://github.com/hacknus/serial-monitor-rust/releases/tag/v0.2.0

EDIT: the latest release (https://github.com/hacknus/serial-monitor-rust/releases/tag/v0.2.1
) now also includes a specific apple silicon binary however, you need to first run this in the terminal:
xattr -rd com.apple.quarantine Serial\ Monitor.app
otherwise macOS will report that the file is damaged...
but you can also try the x86 one

I'm always happy to get feedback! :)

@hacknus hacknus closed this as completed Mar 9, 2024
@ubaldot
Copy link
Author

ubaldot commented Mar 9, 2024

Hey thank you! I will give it a go later on today or tomorrow. :) I will only use the silicon version because I have an M1 MacBook. I will let you know, thanks again!

@hacknus
Copy link
Owner

hacknus commented Mar 9, 2024

I think the apple silicon build is queued for some reason.. use the normal build for macos, it should also run on apple silicon, just not as optimized.

@ubaldot
Copy link
Author

ubaldot commented Mar 10, 2024

Hello! I finally give it a go! Awesome job! I was actually impressed how beauty and easy is the interface.
Some feedbacks:

  1. Some docs would be great to have (I may contribute in that case)
  2. Y-axes lock range
  3. Possibility to collapse the side menu and the bottom display information
  4. Possibility to actually add/remove a dataset in a plot in addition to enabling/disabling it
  5. Possibility to choose colour, thickness and linestyle for each dataset (e.g. "continuous, red, thin", "dashed, blue, thick", etc)
  6. Plotting range units should be "n. points" rather than "#".
  7. I don't use it but perhaps some users may want to use a binary format for data streams.
  8. Many macos users will skip the download if they don't explicitly read ARM in the releases (mind that users are LAZY!).

Screenshot 2024-03-10 at 19 17 32

I will definitely used it for my YouTube channel contents once I will start to move from theory to practice. :)

@hacknus
Copy link
Owner

hacknus commented Mar 11, 2024

  1. Some docs would be great to have (I may contribute in that case).

Agreed! There is also a feature request (#76 ) open about a how-to start guide, but I haven't gotten around to that...

  1. Y-axes lock range.

👍🏻

  1. Possibility to collapse the side menu and the bottom display information.

👍🏻

  1. Possibility to actually add/remove a dataset in a plot in addition to enabling/disabling it.

Not quite sure what you mean, but any further interaction with the legend would need to be implemented in egui

  1. Possibility to choose colour, thickness and linestyle for each dataset (e.g. "continuous, red, thin", "dashed, blue, thick", etc).

👍🏻

  1. Plotting range units should be "n. points" rather than "#".

👍🏻

  1. I don't use it but perhaps some users may want to use a binary format for data streams.

👍🏻

  1. Many macos users will skip the download if they don't explicitly read ARM in the releases (mind that users are LAZY!).

haha fair enough, it will be renamed for the next release

Thank you very much for the feedback, really appreciate it!

@ubaldot
Copy link
Author

ubaldot commented Mar 15, 2024

Here I am. Sorry, I finally found some time to follow up.

Not quite sure what you mean, but any further interaction with the legend would need to be implemented

I'll make an example: say that I have 10 signals and I want to plot 3 in the first graph and 7 in the second graph. As it is not, I would have 10 signals and 10 legend in both the graphs. Then, I can disable 7 signals in the first graph and 3 signals in the second graph to hide them, but the legend would still have 10 items in both the graphs. Hope it clarifies a bit :)

@hacknus
Copy link
Owner

hacknus commented Mar 19, 2024

Ah okay, I see. yes, we could put a color picker and a plot-selection-dropdown menu next to the text-field where we type in the label/name of the dataset? something like this?

@ubaldot
Copy link
Author

ubaldot commented Mar 19, 2024

Yes, for the plot selection.
For the color I would conveniently use the triple (color, linestyle, thickness) instead, where for color one could take the color engine of the OS, linestyle is a dropdown menu where user can choose ‘continuous’, ‘dashed’, etc and thickness is a positive integer.
Or, if we want to stay in standard, we can drop the thickness and use the standard triple (color, linestyle, marker) instead - perhaps it is even better this way.

I can make a sketch on paper tomorrow to me even more clear (now I am not at home).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants