Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What can be inproved #1

Closed
3 tasks done
sabatesduran opened this issue Feb 1, 2018 · 1 comment
Closed
3 tasks done

What can be inproved #1

sabatesduran opened this issue Feb 1, 2018 · 1 comment

Comments

@sabatesduran
Copy link

sabatesduran commented Feb 1, 2018

  • Right now you are creating multiple events and you could create 1 event that executes 2 functions.
document.getElementById('leaderPicker').addEventListener('click', () => {
  leaderPicker();
  reviewersList();
});
  • As you said in you slack message you have repetitions, try to clone the original array and use the new array for the forEach, every time you iterate througth student delete the element that you just used for the table.

  • Doing the second task you can still have a problem, someone could have himself as reviewer.

@hackoor83
Copy link
Owner

Thanks @sabatesduran , I have done some modifications and I believe that improved the app. I would love to hear your opinion on this new version. I have renamed the files for the new version by adding '_V1' as a suffix for each file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants