Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink FluentDate + end dates #84

Closed
jarz opened this issue Jan 1, 2016 · 3 comments
Closed

Rethink FluentDate + end dates #84

jarz opened this issue Jan 1, 2016 · 3 comments
Labels
bug in progress willfix
Milestone
v1.6.0

Comments

@jarz
Copy link

jarz commented Jan 1, 2016

HMR automagically subs today for present/now/current @ fluent-date.js:32. That means my current job always ends this month.
@hacksalot
Copy link
Owner

Agreed. Reworking this per fresh-standard/fresh-themes/issues/23.

@jjanusch jjanusch mentioned this issue Jan 1, 2016
Merged
@robertmain
Copy link

So is this issue intended to address HMR putting in the current date for the end date whenever you compile? To my mind, omitting an end date should be interpreted to mean "Still continuing" so a job with no end date should read "01-01-2001" - "Present"

@hacksalot hacksalot added this to the v1.6.0 milestone Jan 24, 2016
@hacksalot
Copy link
Owner

Fixed in 1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in progress willfix
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@jarz @robertmain @hacksalot