[Bug]: Actions on Members who left Failing

[0xEmma]

Describe the bug

When trying to add a note/ban users who have left the server, this action fails

To reproduce

User leaves server
try to add note / ban / whois / history

Expected behavior

Note gets added / user gets banned & command should accept INT input

Also should be able to run /whois on an HTB ID, or a user who has left the server, which is not possible.

same with history not allowed to be run on left users

Relevant log output

No response

Additional context

No response

[0xEmma]

From what we had to do previously, iirc its a matter of if get_user fails for the guild, just use their UID to insert into the database, or get the user object instead of member object

[dimoschi]

@0xEmma so we want to able to ban users who may not be members?

[0xEmma]

Correct, we should be able to ban/pull history/add notes/whois on non-members. This can be useful is several cases and is an urgent issue.

This is needed because:

• User spams and leaves: cant ban(this is the issue that prompted this, we're unable to ban a user who spammed DM's soliciting illegal services)
• User files a ban appeal: unable to pull up history
• User joins on new account, unable to whois or pull history to remove token
• Unable to add note on user who left

[daanbreur]

Personally also find that pretty useful. But how does that work with GDPR?

[0xEmma]

Personally also find that pretty useful. But how does that work with GDPR?

GDPR has no effect with this. We're not storing any PII afaik, this is just standard discord bot functions.
Feature is not just useful, it is needed for core functionality.

[daanbreur]

You are storing the full infraction history together with a user. That is PII.
Even Ubisoft and others have to delete in-game saves after 2 years cause GDPR, and save games really don't have much PII.

[0xEmma]

You are storing the full infraction history together with a user. That is PII. Even Ubisoft and others have to delete in-game saves after 2 years cause GDPR, and save games really don't have much PII.

Open a separate issue for that, please. This ticket just adds the ability to add/ban data from left users, data is still stored on users who had data attached when joined.

[daanbreur]

True, I just was asking about the part of adding to left users. Which you might to think twice about if this really is against GDPR, else this feature is fine and useful

[0xEmma]

True, I just was asking about the part of adding to left users. Which you might to think twice about if this really is against GDPR, else this feature is fine and useful

As i said, please raise a separate issue for this. While i agree that GDPR can be a concern on users who have left, this PR doesnt change the fact we store infractions on users who have left if that data was added while theyre in the server.