Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Types folder #21

Closed
ankitwww opened this issue Oct 12, 2022 · 3 comments
Closed

Refactor Types folder #21

ankitwww opened this issue Oct 12, 2022 · 3 comments
Assignees
@rodolfonei
Labels
good first issue Good for newcomers
Milestone
2210 Week 2 Release

Comments

@ankitwww
Copy link
Contributor

ankitwww commented Oct 12, 2022 •
edited

Separate every type in a single file, and fix their references across the repo.
types\SearchResults.tsx can be ignored, but PREntry needs to be broken into single file and a better name
@ankitwww ankitwww added the good first issue Good for newcomers label Oct 12, 2022
@rodolfonei
Copy link
Contributor

I would like to work on this one, please

@ankitwww
Copy link
Contributor Author

@rodolfonei go ahead.

@ankitwww ankitwww added this to the 2210 Week 2 Release milestone Oct 12, 2022
@rodolfonei rodolfonei mentioned this issue Oct 12, 2022
Merged
@ankitwww
Copy link
Contributor Author

Thanks for your help @rodolfonei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodolfonei rodolfonei

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
2210 Week 2 Release
Development

No branches or pull requests
2 participants
@ankitwww @rodolfonei