Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex tab item displays in wrong position when a keyboard covers the app bar #67

Closed
khoasvn opened this issue Jul 9, 2020 · 7 comments
Labels
bug Something isn't working detail required Extra attention is needed working on it Some work is to be done

Comments

@khoasvn
Copy link

khoasvn commented Jul 9, 2020

Describe the bug

The convex item displays in wrong position after a keyboard (when using TextField) covers it.

Environment details

[√] Flutter (Channel beta, 1.19.0-4.3.pre, on Microsoft Windows [Version 10.0.19041.329], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[√] VS Code (version 1.46.1)

Flutter 1.19.0-4.3.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 8fe7655ed2 (8 days ago) • 2020-07-01 14:31:18 -0700
Engine • revision 9a28c3bcf4
Tools • Dart 2.9.0 (build 2.9.0-14.1.beta)
dependencies:
  convex_bottom_bar: 2.2.4

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'ReviewScreen'
  2. Click on 'PhoneNumberTextField'
  3. Dismiss the keyboard after editting the 'PhoneNumberTextField'
  4. See error

Screenshots

bug

@avenwu
Copy link
Contributor

avenwu commented Jul 9, 2020

looks like the initial index is messed up. please provide the code how you are using the appbar

@avenwu avenwu added the detail required Extra attention is needed label Jul 9, 2020
@khoasvn
Copy link
Author

khoasvn commented Jul 10, 2020

HomeSreen (where I've used ConvexAppBar)
https://gist.github.com/khoaSB/0bf419da6b166af391c3d36b0a077f73

ReviewSubmitButton (the app will navigate back to ContactScreen after user click on the submit button)
https://gist.github.com/khoaSB/a87ccc567899e96fde7dd532c8631e3c

MenuBloc (the Convex App Bar will be called to change index via bloc events)
https://gist.github.com/khoaSB/6b573803afbde5f5602f32f20db7a29f

Ps: I have removed unnecessary codes. Thanks for your attention!

@avenwu
Copy link
Contributor

avenwu commented Jul 10, 2020

The code is quit complicated😂, it's hard to analyze. Can you provide a simplified runnable repo

@avenwu avenwu added the working on it Some work is to be done label Jul 10, 2020
@khoasvn
Copy link
Author

khoasvn commented Jul 10, 2020

I hope it will help -> convex_bug_demo

@avenwu avenwu added the bug Something isn't working label Jul 13, 2020
@avenwu
Copy link
Contributor

avenwu commented Jul 13, 2020

@khoasvn try with v2.2.5

@avenwu avenwu closed this as completed Jul 13, 2020
@khoasvn
Copy link
Author

khoasvn commented Jul 14, 2020

Hi @avenwu, sorry for bothering you again. I just have discovered another bug with the same behavior.
Please pull this repo: convex_bug_demo [updated].
The bug happens when I tried to set the initialActiveIndex (I didn't set it in the previous version).

@avenwu
Copy link
Contributor

avenwu commented Jul 16, 2020

😅

@avenwu avenwu added this to the v2.3.0 New Style Feature milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detail required Extra attention is needed working on it Some work is to be done
Projects
None yet
Development

No branches or pull requests

2 participants