Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code #143

Closed
remarcmij opened this issue Jun 19, 2018 · 2 comments
Closed

Duplicated code #143

remarcmij opened this issue Jun 19, 2018 · 2 comments
Labels
front-end Involves the front-end

Comments

@remarcmij
Copy link
Contributor

The Guest, Students and Teachers components in the src/components/Users folder are virtually identical. This should be replaced with a single component that receives a role prop.
@remarcmij remarcmij added the front-end Involves the front-end label Jun 19, 2018
@remarcmij
Copy link
Contributor Author

Fix Duplicated Code issue

mahmutkaya added a commit to mahmutkaya/hyfer that referenced this issue Jun 24, 2018
@mahmutkaya
Fixed Duplicated Code issue HackYourFuture#143
658a1ab
mahmutkaya added a commit to mahmutkaya/hyfer that referenced this issue Jun 27, 2018
@mahmutkaya
Fixed Duplicated Code issue HackYourFuture#143
8a98fe3
mahmutkaya added a commit to mahmutkaya/hyfer that referenced this issue Jun 30, 2018
@mahmutkaya
no more duplicated code for 'users component': issue HackYourFuture#143
2e9977e
@remarcmij
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
front-end Involves the front-end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remarcmij