Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit Eslint config and stick with a single code formatting style #28

Closed
GeorgeSapkin opened this issue Mar 8, 2018 · 1 comment
Closed

Add explicit Eslint config and stick with a single code formatting style #28

GeorgeSapkin opened this issue Mar 8, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@GeorgeSapkin
Copy link
Member

GeorgeSapkin commented Mar 8, 2018 •
edited

There is no .eslintrc in the project and different files have different formatting which makes it difficult to read.

  • Some files have both tabs and spaces in the same file: Attendance.js
  • Sometimes closing ; is used and sometimes not

Pick one style, configure it and stick with it.
@GeorgeSapkin GeorgeSapkin added the enhancement New feature or request label Mar 8, 2018
@remarcmij
Copy link
Contributor

We are adopting the Airbnb Style Guide and corresponding ESLint configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remarcmij @GeorgeSapkin