Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine: strip automatically return when in end position #254

Closed
W95Psp opened this issue Sep 19, 2023 · 1 comment
Closed

Engine: strip automatically return when in end position #254

W95Psp opened this issue Sep 19, 2023 · 1 comment
Labels
engine Issue in the engine good first issue Good for newcomers P2 Medium priority

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Sep 19, 2023 •
edited
Loading

Any return statement currently triggers the monadic rewrite phase, which lifts everything to a monad.

When a return statement is in end position, we should instead just drop it.
@W95Psp W95Psp added good first issue Good for newcomers engine Issue in the engine labels Dec 20, 2023
@W95Psp W95Psp mentioned this issue Dec 21, 2023
Open
12 tasks
@W95Psp W95Psp added the P2 Medium priority label Jan 2, 2024
@W95Psp W95Psp mentioned this issue Mar 12, 2024
Merged
@W95Psp
Copy link
Collaborator Author

W95Psp commented Mar 14, 2024

Done in #559

@W95Psp W95Psp closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine Issue in the engine good first issue Good for newcomers P2 Medium priority
Projects
hax
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@W95Psp