Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds numbers to equal atom names in HETATM entries #71

Closed
joaomcteixeira opened this issue Aug 3, 2020 · 6 comments · Fixed by #75
Closed

Adds numbers to equal atom names in HETATM entries #71

joaomcteixeira opened this issue Aug 3, 2020 · 6 comments · Fixed by #75
Assignees

Comments

@joaomcteixeira
Copy link
Member

A user requested:

Fix atom names in Het Groups - ie where all carbons are called 'C',
they should be renamed 'C1', 'C2', etc, and the same for other elements.

Developers, do you feel is there a tool already to accommodate this, or should we go for: pdb_numhetatoms?

@JoaoRodrigues @amjjbonvin @brianjimenez @mtrellet

@JoaoRodrigues
Copy link
Member

I'd be in favor of doing two changes related to this issue:

  1. Add a check to pdb_validate to throw a warning on duplicate atom names in the same residue. Or maybe add a new tool?
  2. Add a new tool that fixes this by renaming atoms with their original name + a number - and throw and error if the name grows beyond 4 characters: pdb_rename?

Also comes to mind that our names are maybe not super intuitive. For instance pdb_reres should maybe be pdb_numres or pdb_reatom should be pdb_reserial. What do you think?

@amjjbonvin
Copy link
Member

amjjbonvin commented Aug 11, 2020 via email

@joaomcteixeira
Copy link
Member Author

So, the new pdb_rename would work only on HETATM as requested by the user, right? Or do you want to perform the whole action in all ATOM and HETATM?

@amjjbonvin
Copy link
Member

amjjbonvin commented Aug 11, 2020 via email

@JoaoRodrigues
Copy link
Member

I'd leave it more generic because anyway, ATOM names should be unique but, just in case...

A new tool it is then: pdb_rename ! I'll handle it, need to exercise some Python muscles :)

@joaomcteixeira
Copy link
Member Author

welcome back 😉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants