Be explicit about setNames.

Closes #734. Fixes #772.

DESCRIPTION

@@ -26,7 +26,8 @@ Imports:
     rstudioapi (>= 0.2.0),
     jsonlite,
     roxygen2 (>= 4.1.0),
-    rversions
+    rversions,
+    stats
 Suggests:
     testthat (>= 0.7),
     BiocInstaller,

NEWS.md

@@ -1,5 +1,8 @@
 # devtools 1.7.1.9000
 
+* Explicitly refer to `stats::setNames()` to avoid problems (#734, #772) when
+  using devtools inside another package.
+
 * New `dr_devtools()` runs some common diagnostics. It is run automatically
   by `release()` to ensure that you have the latest version of devtools and R
   before submitting to CRAN (#592).

R/install-github.r

@@ -212,7 +212,7 @@ parse_git_repo <- function(path) {
     username_rx, repo_rx, subdir_rx, ref_or_pull_or_release_rx)
 
   param_names <- c("username", "repo", "subdir", "ref", "pull", "release", "invalid")
-  replace <- setNames(sprintf("\\%d", seq_along(param_names)), param_names)
+  replace <- stats::setNames(sprintf("\\%d", seq_along(param_names)), param_names)
   params <- lapply(replace, function(r) gsub(github_rx, r, path, perl = TRUE))
   if (params$invalid != "")
     stop(sprintf("Invalid git repo: %s", path))

R/topic-index.r

@@ -45,7 +45,7 @@ find_topic <- function(topic) {
   for (pkg in pkgs) {
     path <- getNamespaceInfo(pkg, "path")
     rd <- find_pkg_topic(path, topic)
-    if (!is.null(rd)) return(setNames(file.path(path, "man", rd), path))
+    if (!is.null(rd)) return(stats::setNames(file.path(path, "man", rd), path))
   }
 
   NULL

R/utils.r

@@ -2,7 +2,7 @@
 # whether each exists and is a directory.
 dir.exists <- function(x) {
   res <- file.exists(x) & file.info(x)$isdir
-  setNames(res, x)
+  stats::setNames(res, x)
 }
 
 compact <- function(x) {

tests/testthat/test-github.r

@@ -61,7 +61,7 @@ mock_github_GET <- function(path) {
 }
 
 test_that("GitHub references are resolved correctly", {
-  default_params <- as.list(setNames(nm=c("repo", "username")))
+  default_params <- as.list(stats::setNames(nm=c("repo", "username")))
   with_mock("github_GET", mock_github_GET, {
     expect_equal(github_resolve_ref(NULL, list())$ref, "master")
     expect_equal(github_resolve_ref("some-ref", list())$ref, "some-ref")