Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools 1.12.0 install_github fails installing when Imports are defined. #1354

Closed
mariodejung opened this issue Sep 26, 2016 · 4 comments
Closed
Labels
install reprex needs a minimal reproducible example

Comments

@mariodejung
Copy link

mariodejung commented Sep 26, 2016

I am trying to install a package from a github repository but the installation crashes with a strange behaviour.

devtools::install_github("mariodejung/cfpscripts", ref = "develop", dependencies = FALSE)
Using GitHub PAT from envvar GITHUB_PAT
Downloading GitHub repo mariodejung/cfpscripts@develop
from URL https://api.github.com/repos/mariodejung/cfpscripts/zipball/develop
Installing cfpscripts
Downloading GitHub repo mariodejung/rMQanalysis@develop
from URL https://api.github.com/repos/mariodejung/rMQanalysis/zipball/develop
Error in stop(github_error(request)) : Not Found (404)

The repository is private, so this is not very reproducible. But when I install my package, install_github starts to install another package which is defined in my DESCRIPTION file as Imports: and at that point, the function fails.
The package rMQanalysis is already installed, thats why I switched dependencies=FALSE.

The issue started with devtools 1.12.0... With 1.11.1 it works as expected. So maybe there is a bug.

I already asked a question in stack overflow, but it took me some time to figure out where the problem is. http://stackoverflow.com/questions/39657795/problems-installing-r-package-via-devtools-install-github
If I remove the Imports: rMQanalysis or downgrade to devtools 1.11.1 everything works normal.

@mariodejung mariodejung changed the title devtools 1.12.0 install_github fails installing when Imports devtools 1.12.0 install_github fails installing when Imports are defined. Sep 27, 2016
@hadley hadley added bug an unexpected problem or unintended behavior install reprex needs a minimal reproducible example and removed bug an unexpected problem or unintended behavior labels Nov 3, 2016
@hadley
Copy link
Member

hadley commented Nov 3, 2016

Could you please try making a minimal reprex with a public facing repo? Otherwise it's unlikely we'll be able to track down the problem.

@jcmsb
Copy link

jcmsb commented Dec 13, 2016

I am also seeing this on private repos that depend on other private repos - the error message is the same as you get if you try to access a private repo without the auth token. I have not reproduced this on public repos. I speculate that the process is seeing the import, assuming it is public and trying to download it without passing through the auth token.

@hadley
Copy link
Member

hadley commented Aug 2, 2017

In that case, it's probably a duplicate of #1280

@hadley hadley marked this as a duplicate of #1280 Aug 2, 2017
@hadley hadley closed this as completed Aug 2, 2017
@lock
Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install reprex needs a minimal reproducible example
Projects
None yet
Development

No branches or pull requests

3 participants