Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release() should call document() #1516

Closed
krlmlr opened this issue May 23, 2017 · 5 comments
Closed

release() should call document() #1516

krlmlr opened this issue May 23, 2017 · 5 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented May 23, 2017

before checking that all files are committed to Git. (Sorry if this has been suggested before.)

@jimhester
Copy link
Member

It already implicitly calls document when it runs the package check, because the default is document = TRUE. It is true this is after the Git checks.

@hadley
Copy link
Member

hadley commented Aug 1, 2017

I think we'll probably totally rethink the release() function in the near future. I don't use it any more since it just seems to cause me more hassle than it saves.

@hadley hadley closed this as completed Aug 1, 2017
@krlmlr
Copy link
Member Author

krlmlr commented Aug 3, 2017

I don't even remember how to manually upload a package to CRAN ;-) Would be interested to understand the hassle it's causing to you.

@hadley
Copy link
Member

hadley commented Aug 3, 2017

I don't know exactly - it's just some additional friction so I've basically switch to just using submit_cran(). I think it's probably just because my workflow has drifted a bit and so the questions aren't quite right.

@lock
Copy link

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants