ensure that the repo passed to url is lowercase #175
Conversation
See http://stackoverflow.com/questions/12966600/install-bitbucket-in-devtools-case-sensitive repo identifiers within url appear to be always lowercase, despite package name.
| url <- paste("https://bitbucket.org/", username, "/", repo, "/get/", | ||
|
|
||
| # convert repo to lower case in line with bitbucket convention | ||
| repo <- tolower(repo) |
There was a problem hiding this comment.
I think the identing level is slightly off
|
I have to wonder if this is necessary -- |
|
Because it appears that the repo identifier within the bit bucket URL is all lowercase regardless of the r package name capitalization. On 20/10/2012, at 2:26 AM, "Winston Chang" <notifications@github.commailto:notifications@github.com> wrote: I have to wonder if this is necessary -- install_bitbucket accesses a repository by name and installs the package from the repo. Why is desirable to change the name of the repo that the user asks for? — |
|
I've implemented this in 14e0631 . |
See http://stackoverflow.com/questions/12966600/install-bitbucket-in-devtools-case-sensitive
repo identifiers within url appear to be always lowercase, despite package name.