Work around listener errors introduced in #211 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… host and port down through R6 classes.
| @@ -77,3 +77,14 @@ oauth_listener <- function(request_url, is_interactive = interactive(), host = " | |||
| oauth_callback <- function() { | |||
| "http://localhost:1410/" | |||
| } | |||
|
|
|||
| listener_endpoint <- function () | |||
There was a problem hiding this comment.
Can you please follow house style? (e.g. http://r-pkgs.had.co.nz/r.html#style)
…ell. Note that this is required even in non-dockerized versions, e.g. when running RStudio-server from a cluster. The dockerized sitation is worse, in that HTTP_LOCALHOST must be set to 0.0.0.0, while the callback (HTTP_SERVER) must be set to the server's IP address instead. In non-dockerized instances running on a server, both HTTP_LOCALHOST and HTTP_SERVER would simply be the server's IP
|
super useful, thanks Carl |
hadley
added a commit
that referenced
this pull request
May 22, 2015
Work around listener errors introduced in #211
|
Thanks! BTW I only get notifications on comments, not additional commits, so when you're done with requested changes it's helpful to comment with PTAL or similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hadley I've taken the short-cut of just modifying the listener method to read the environmental variables directly, and removed the option to pass down explicit host and port in
oauth_initandoauth_tokenfunctions.I did try modifying the R6 initialization structures to include a
listenerobject that would store this, but am not very solid on R6 methods and their inheritance behavior; or how this would interact with caching. Making so many changes to internal plumbing just to add support for a feature most people would only configure with environmental variables, if at all, seemed unwise, so I opted for this cop-out.Sincere apologies for the incomplete implementation in #211 and also for the imperfect git log history here...