Refactor interp() #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jan 3, 2017
| @@ -319,8 +319,8 @@ fml_default <- function(expr, fn) { | |||
| #' @export | |||
| #' @examples | |||
| #' # The missing argument can be useful to generate calls | |||
| #' f_interp(~f(x = uq(arg_missing()))) | |||
| #' f_interp(~f(x = uq(NULL))) | |||
| #' interp(~f(x = UQ(arg_missing()))) | |||
There was a problem hiding this comment.
so should we promote !! as the default way of unquoting? I'd like that.
hadley
reviewed
Jan 3, 2017
| #' with the evaluated value of \code{x}, and inlines sub-expressions | ||
| #' of the form \code{UQS(x)}. Syntactic shortcuts are provided for | ||
| #' unquoting and unquote-splicing by prefixing with \code{!!} and | ||
| #' \code{!!!}. |
There was a problem hiding this comment.
I really like it but it's your call ;)
There was a problem hiding this comment.
Ok, let's just go with it. I can't see an option that's better (unless we use !!. or !!?)
| #' | ||
| #' # However you need to be a bit careful with operator precedence. | ||
| #' # All arithmetic and comparison operators bind more tightly than `!`: | ||
| #' interp(x ~ 1 + !! (1 + 2 + 3) + 10) |
lionel-
force-pushed
the
feature-interp
branch
from
94b94db
to
62e6c2b
Compare
For symmetry with f_env()
It's going to replace old lazyeval::interp() and support formulas as well as closures.
And allow splicing of language objects (with automatic extraction of quoted curlies)
Caused by function called `splice()`...?
lionel-
force-pushed
the
feature-interp
branch
from
62e6c2b
to
6cfc0ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f_interp()tointerp()and add interpolation of closures.UQS()handle language objects. This is useful for interpolating bodies of closures.!!,!!!, and`!!`()shortcuts for unquoting and splicing.