Add suggestion to run wget with --progress=dot:giga #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @lorenzo |
nvtkaszpir
force-pushed
the
wget
branch
2 times, most recently
from
d2f2d26
to
b513099
Compare
|
that was fast @nvtkaszpir 👏 I'll take a look tomorrow morning |
lorenzo
reviewed
Mar 15, 2021
Fixes hadolint#546 Warn when runnign wget without without --progress flag unless other flags are present (such as quiet/no-verbose/output/append), which usually leads to insane amouts of useless logs when downloaded files are big (usually anything over 5MB becomes annoying) Adding --progress=dot:giga makes output much shorter even for very large files such as AM/ML models etc. See wget manual, search for --progress=dot:giga Signed-off-by: Michał Sochoń <kaszpir@gmail.com>
nvtkaszpir
commented
Mar 15, 2021
|
Great job! |
|
Maybe this rule should prevent those busybox based wget? I wonder if we can just set the rule level to info instead of warning, there are so many Alpine/busybox based images using wget without this support. |
PeterDaveHello
added a commit
to PeterDaveHello/hadolint
that referenced
this pull request
Jun 19, 2021
As @lorenzo mentioned in hadolint#546, it's okay to lower it down. cc hadolint#546 hadolint#566
PeterDaveHello
added a commit
to PeterDaveHello/hadolint
that referenced
this pull request
Jun 19, 2021
As @lorenzo mentioned in hadolint#546, it's okay to lower it down. cc hadolint#546 hadolint#566
lorenzo
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #546
Signed-off-by: Michał Sochoń kaszpir@gmail.com
What I did
How I did it
How to verify it
See new section: